Skip to content

Change layout to new Domoticz style#22

Merged
adrighem merged 5 commits into
adrighem:masterfrom
MadPatrick:master
Jun 14, 2026
Merged

Change layout to new Domoticz style#22
adrighem merged 5 commits into
adrighem:masterfrom
MadPatrick:master

Conversation

@MadPatrick

Copy link
Copy Markdown

No description provided.

@MadPatrick

Copy link
Copy Markdown
Author

change the style.
I hope you like it

Started new branch to catch up with the original

@adrighem

Copy link
Copy Markdown
Owner

Thanks for splitting this out from #20. This is much easier to review now, and the new style direction looks good.

Before I can review this as a pure layout change, can you revert the behavior removals in pypluginstore.html?

  • Lines 284-288: please keep the Restart Domoticz button in the header.
  • Lines 336-342 in init(): please keep wiring restartDomoticz to that button.
  • Lines 421-429 in loadPlugins(): please keep updateStatusCache and managerKey.
  • Lines 541-545 in renderPlugins(): please keep the update-status classes/title and the managerKey check that hides Remove for PyPluginStore itself.
  • Before line 586: please keep the restartDomoticz() function.

After those are restored, this should be a focused style-only PR and much easier to approve.

@MadPatrick

Copy link
Copy Markdown
Author

i missed your latest update of the restart button.
Now changed.

@adrighem

Copy link
Copy Markdown
Owner

Thanks for the update. I think something went wrong while applying the latest changes.

The newest version of pypluginstore.html appears to have removed the actual page content and script. It now starts directly with :root { and only contains CSS. The <style> wrapper, the HTML markup, and the full <script> block are gone.

That is why CI is failing now:

pypluginstore.html does not contain an inline script

So this looks like an accidental partial overwrite rather than just a layout change. Could you restore the full pypluginstore.html content and then re-apply only the style changes on top of it?

@MadPatrick

Copy link
Copy Markdown
Author

oeps.... copy paste error
Now it should be right

@adrighem

Copy link
Copy Markdown
Owner

Thanks, this version is much better. The page content and script are restored, CI is green again, and the restart/update-status behavior looks back in place.

I see one small thing left before this is ready from my side: the markup restores .header-actions and .btn-restart, but the matching CSS for those classes is still missing. That means the Restart Domoticz button is functional again, but it will not get the intended header layout / button styling.

Could you add the styling for .header-actions and .btn-restart back into the new theme? After that this looks good to merge.

We can always make further updates later

@adrighem adrighem left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iterations on this. The PR is clean and CI is green; I’ll handle the remaining update-button styling follow-up after merge.

@adrighem adrighem merged commit 41dbedb into adrighem:master Jun 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants